Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-1465] Fix serialization error of chart data when X is Date #2550

Closed
wants to merge 1 commit into from

Conversation

mrkm4ntr
Copy link
Contributor

@mrkm4ntr mrkm4ntr commented Aug 29, 2017

Dear Airflow maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    In Python 3, the example on https://airflow.incubator.apache.org/profiling.html#chart-screenshot fails with the error message like 1496268000000 is not JSON serializable or Object of type 'int64' is not JSON serializable.
    The numpy.int64 values can't be converted to native types in df[col].index.tolist(), but df[col].index.get_values() returns pandas.Series and pandas.Series.tolist() can convert them to native types.
    See below.

chart error

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

There are no tests of rendering chart originally, and that's hard to test.

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@codecov-io
Copy link

codecov-io commented Aug 29, 2017

Codecov Report

Merging #2550 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2550      +/-   ##
==========================================
- Coverage   70.88%   70.85%   -0.03%     
==========================================
  Files         150      150              
  Lines       11585    11585              
==========================================
- Hits         8212     8209       -3     
- Misses       3373     3376       +3
Impacted Files Coverage Δ
airflow/www/views.py 69.99% <0%> (ø) ⬆️
airflow/jobs.py 77.67% <0%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a4b024...4642455. Read the comment docs.

@bolkedebruin
Copy link
Contributor

Please add tests. Absence of tests is no reason to not add any. Thanks!

@mrkm4ntr
Copy link
Contributor Author

I attempted to add a test, but it was blocked by #2598.

@ron819
Copy link
Contributor

ron819 commented Dec 10, 2018

@mrkm4ntr are you still working on this PR?

@ron819
Copy link
Contributor

ron819 commented Jan 31, 2019

Wasn't this fixed in Pandas?
pandas-dev/pandas@b2009e6

@stale
Copy link

stale bot commented Sep 3, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Sep 3, 2019
@stale stale bot closed this Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale PRs per the .github/workflows/stale.yml policy file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants