-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changing to task decorator in docs from classic operator use #25711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bowrna
force-pushed
the
task-decorator-in-docs
branch
from
August 18, 2022 17:46
6b93660
to
f6ea39b
Compare
uranusjr
reviewed
Aug 19, 2022
Bowrna
force-pushed
the
task-decorator-in-docs
branch
2 times, most recently
from
August 23, 2022 16:29
ab2adb3
to
322f474
Compare
Bowrna
force-pushed
the
task-decorator-in-docs
branch
4 times, most recently
from
September 2, 2022 08:39
08248eb
to
f1e9c39
Compare
uranusjr
reviewed
Sep 2, 2022
uranusjr
reviewed
Sep 2, 2022
uranusjr
reviewed
Sep 2, 2022
Bowrna
force-pushed
the
task-decorator-in-docs
branch
5 times, most recently
from
September 2, 2022 18:04
32ccbb0
to
87c3765
Compare
@uranusjr Is there any more place where I can improve? |
Bowrna
force-pushed
the
task-decorator-in-docs
branch
from
September 6, 2022 09:44
87c3765
to
1553283
Compare
uranusjr
reviewed
Sep 6, 2022
uranusjr
reviewed
Sep 6, 2022
uranusjr
reviewed
Sep 6, 2022
uranusjr
reviewed
Sep 6, 2022
uranusjr
reviewed
Sep 6, 2022
10 tasks
1 task
Bowrna
force-pushed
the
task-decorator-in-docs
branch
from
September 9, 2022 17:57
1553283
to
d0bc251
Compare
uranusjr
reviewed
Sep 12, 2022
As suggested in commented by uranusjr Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Bowrna
force-pushed
the
task-decorator-in-docs
branch
from
September 13, 2022 09:03
d0bc251
to
3f609b4
Compare
@uranusjr I have left some questions to clarify in this PR. Can you help me with them when you have time? thanks |
uranusjr
approved these changes
Sep 16, 2022
potiuk
approved these changes
Sep 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
jedcunningham
pushed a commit
that referenced
this pull request
Sep 23, 2022
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit 3d76733)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #25319
This contains a fix for docs under the concepts folder mentioned in the above issue. Made changes only to the code part and still relevant doc changes have to be updated.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.