Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken auto-refresh in Airflow 2.3.4 #25950

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Conversation

cloventt
Copy link
Contributor

@cloventt cloventt commented Aug 25, 2022

In PR #25042 the merged change included a bug that prevents the page from auto-refreshing if there aren't any manual runs on the page. We also want to auto-refresh for scheduled runs.

I've also added more complete unit tests for the expected behaviour.

This PR closes #25949

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Aug 25, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 25, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

In PR apache#25042 the merged change included a bug that prevents the page
from auto-refreshing if there are anything other than manual runs on the
page. We also want to auto-refresh for scheduled runs.

I've also added more complete unit tests for the expected behaviour.
@potiuk potiuk merged commit 37ec752 into apache:main Aug 25, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 25, 2022

Awesome work, congrats on your first merged pull request!

ephraimbuddy pushed a commit to astronomer/airflow that referenced this pull request Aug 25, 2022
In PR apache#25042 the merged change included a bug that prevents the page
from auto-refreshing if there are anything other than manual runs on the
page. We also want to auto-refresh for scheduled runs.

I've also added more complete unit tests for the expected behaviour.

(cherry picked from commit 37ec752)
@jedcunningham jedcunningham added the type:bug-fix Changelog: Bug Fixes label Sep 12, 2022
@ephraimbuddy ephraimbuddy added this to the Airflow 2.4.0 milestone Sep 14, 2022
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jan 30, 2023
Cherry-picked changes from community:
apache/airflow#25950

Change-Id: I52828169824a24995773c8b27ace2003d2534e58
GitOrigin-RevId: 9ded1a989e6613ec5fce485e98b78d057724f5a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-refresh is broken in 2.3.4
5 participants