Rewrite recursion into iteration #26175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps to avoid RecursionError when viewing the graph view of a dag with many tasks
ephraimbuddy
requested review from
ryanahamilton,
ashb and
bbovenzi
as code owners
potiuk
approved these changes
Sep 6, 2022
ashb
changed the title
ephraimbuddy
force-pushed
the
recursion-iteration
branch
from
369cf32
to
beed3da
Compare
ashb
approved these changes
Sep 6, 2022
1 task
ashb
pushed a commit
to astronomer/airflow
that referenced
this pull request
Sep 7, 2022
In apache#26175, edge detection was changed to use iteration instead of recursion, however it wasn't keeping track of the parent tasks. This changes the set we iterate over to be `(task, {children})` pairs instead of just adding all the children tasks themselves.
ashb
pushed a commit
that referenced
this pull request
Sep 7, 2022
In #26175, edge detection was changed to use iteration instead of recursion, however it wasn't keeping track of the parent tasks. This changes the set we iterate over to be `(task, {children})` pairs instead of just adding all the children tasks themselves.
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jan 30, 2023
Cherry-picked changes: Rewrite recursion into iteration apache/airflow#26175 Rewrite recursion into iteration apache/airflow#25898 Change-Id: I529f90aae79ad2716b9282e9b70db91a4f64d9f7 GitOrigin-RevId: dae6b05f8266ccff97e1a565e36a5f580db4c79d
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jan 30, 2023
Cherry-picked changes: Rewrite recursion into iteration apache/airflow#26175 Rewrite recursion into iteration apache/airflow#25898 Change-Id: I3d886329b1d856c4b276d265dd7750dae2b200ba GitOrigin-RevId: 37b365dc035d3e23961683e322b214fb937fab99
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps to avoid RecursionError when viewing the graph
view of a dag with many tasks
Much like #25898