Work around pyupgrade edge cases #26384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:dev-tools
area:providers
provider:google
uranusjr
force-pushed
the
workaround-cattrs-lazy-annotation
branch
from
9ac0d40
to
16c14f4
Compare
|
Ah nice! Would be great if it works :) |
uranusjr
force-pushed
the
workaround-cattrs-lazy-annotation
branch
from
16c14f4
to
05032fe
Compare
uranusjr
force-pushed
the
workaround-cattrs-lazy-annotation
branch
from
05032fe
to
aa58215
Compare
|
Seems to work |
|
Merged and cherry-picked to v2-4 branch :) |
ashb
reviewed
Sep 14, 2022
| # annotation expressions at runtime, and Python before 3.9.0 does not lazily | ||
| # evaluate those. Putting the expression in a top-level assignment statement | ||
| # communicates this runtime requirement to pyupgrade. | ||
| BaseOperatorClassList = List[Type[BaseOperator]] |
There was a problem hiding this comment.
We're working on how we can remove cattrs #26130 so hopefully we can remove this soon.
ephraimbuddy
pushed a commit
that referenced
this pull request
Sep 14, 2022
(cherry picked from commit 9444d97)
ephraimbuddy
added
the
type:misc/internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #26290