-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add container_name option for SparkKubernetesSensor #26560
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
hi @jedcunningham, could you please take a look at my PR? |
Hi @hanna-liashchuk thanks for taking the time to work on this. One thing in this regard is that the container name should probably be overridable |
@bbenzikry, I was aiming to do it as a parameter for SparkKubernetesSensor, by analogy with other input parameters, so the user can specify it if it's different from the default. Do I miss some parts of this implementation? Please advice |
@hanna-liashchuk , what I meant by the comment isn't necessarily a code issue or a blocker for the PR ( sorry if that was the implication ) but just that it should be taken into consideration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Random error - merging.
Awesome work, congrats on your first merged pull request! |
closes: #18468
closes: #23114
In case if a SparkApplications has a sidecar container, SparkKubernetesSensor fails to retrieve logs for the application because the container name is not specified. According to this constants, Spark driver container always named "spark-kubernetes-driver".
Error message look like this:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.