Grid, fix 404 taskInstance errors #26575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrejeambrun
requested review from
ryanahamilton,
ashb and
bbovenzi
as code owners
boring-cyborg
bot
added
area:UI
pierrejeambrun
changed the title
pierrejeambrun
force-pushed
the
fix-grid-warnings
branch
from
dd27743
to
32eb019
Compare
dstandish
approved these changes
Sep 21, 2022
pierrejeambrun
changed the title
|
I like your approach of splitting it into 2 tables more. When you rebase your branch. Let's keep that. |
bbovenzi
reviewed
Sep 22, 2022
pierrejeambrun
force-pushed
the
fix-grid-warnings
branch
2 times, most recently
from
28afb44
to
6eb2c1a
Compare
pierrejeambrun
force-pushed
the
fix-grid-warnings
branch
from
6eb2c1a
to
7b4a8a0
Compare
Ok, i did that and updated the titles so we have something consistent with the 'Task Actions' title: |
|
nice, thanks, yeah i knew the formatting was off but could not figure out what was wrong ... this looks great... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a few warnings due to(fixed in #26551)validateDOMNestingin the grid view (cf screenshot) -> split the table into two distinct tables with separate 'titles'. Took the opportunity to slightly improve spacing between the tables.We also had a few 404 errors when requesting the
useTaskInstancefor groups, by clicking on the details of a task group. (cf screenshot):