-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add env-file parameter to Docker Operator #26951
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
I think it would be great to get it rebased if the tests fail. |
a048395
to
bf05839
Compare
* Docker Operator takes a templateable env-file with environment variables to set in the container
* docker-provider dotenv dependency included in `provider_dependencies.json`
bf05839
to
11e1e32
Compare
Thank you @pierrejeambrun and @eladkal |
Awesome work, congrats on your first merged pull request! |
Cool addition to the Docker Operator. Thanks! |
Thank you for the guidance @potiuk ! |
The change allows for passing a templateable
.env
file to Docker Operator to set the mentioned environment variables in the container. Passing more than a handful env variables might be cumbersome withenvironment
,env-file
would make it easier.Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.