Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env-file parameter to Docker Operator #26951

Merged
merged 7 commits into from
Oct 28, 2022

Conversation

sshivprasad
Copy link
Contributor

The change allows for passing a templateable .env file to Docker Operator to set the mentioned environment variables in the container. Passing more than a handful env variables might be cumbersome with environment, env-file would make it easier.


Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Oct 9, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@sshivprasad sshivprasad marked this pull request as draft October 9, 2022 18:41
@sshivprasad sshivprasad marked this pull request as ready for review October 10, 2022 10:05
@sshivprasad sshivprasad marked this pull request as draft October 12, 2022 13:27
@sshivprasad sshivprasad marked this pull request as ready for review October 12, 2022 15:42
@potiuk
Copy link
Member

potiuk commented Oct 23, 2022

I think it would be great to get it rebased if the tests fail.

@sshivprasad sshivprasad force-pushed the docker_env_file branch 4 times, most recently from a048395 to bf05839 Compare October 27, 2022 13:24
@sshivprasad
Copy link
Contributor Author

Thank you @pierrejeambrun and @eladkal

@potiuk potiuk merged commit 1add2f7 into apache:main Oct 28, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 28, 2022

Awesome work, congrats on your first merged pull request!

@potiuk
Copy link
Member

potiuk commented Oct 28, 2022

Cool addition to the Docker Operator. Thanks!

@sshivprasad
Copy link
Contributor Author

Thank you for the guidance @potiuk !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants