Update google hooks to prefer non-prefixed extra fields #27023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of airflow 2.3 we no longer need to use prefixed name in extra purely for web UI compat. So now we update the providers to take advantage of this, while still maintaining backcompat for conns defined the old way.
dstandish
requested review from
eladkal,
turbaszek,
kaxil,
potiuk and
mik-laj
as code owners
boring-cyborg
bot
added
area:providers
area:secrets
area:system-tests
kind:documentation
provider:amazon-aws
| @@ -127,6 +127,19 @@ def __init__(self): | |||
| RT = TypeVar('RT') | |||
|
|
|||
|
|
|||
| def get_field(extras: dict, field_name: str): | |||
| """Get field from extra, first checking short name, then for backcompat we check for prefixed name.""" | |||
| if field_name.startswith('extra_'): | |||
There was a problem hiding this comment.
Can we check for the exact string extra__ . WDYT ?
eladkal
approved these changes
Oct 21, 2022
dstandish
commented
Oct 22, 2022
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of airflow 2.3 we no longer need to use prefixed name in extra purely for web UI compat. So now we update the providers to take advantage of this, while still maintaining backcompat for conns defined the old way.