-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BugFix - Druid Airflow Exception to about content #27174
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
- Good choice for language Co-authored-by: Niko <onikolas@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uranusjr has run the build workflow on you PR and there were some static check failures, you'll need to patch those up. Do also rebase your branch since some changes were recently merged to standardize quoting in the Airflow codebase. |
Thanks Nikolas. I am very busy for this weekend. I will check on Friday. P.S @o-nikolas Is this problem about character number or write type? I don't know. |
No worries, thanks for sticking with it :)
This is mypy warning you that at least one of the strings you're formatting here is a byte string, and that Python 3 doesn't handle this edge case gracefully when formatting with f-strings. |
You need to rebase I am afraid |
@potiuk Today, I will rebase and change. Thanks to approved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed f string to format type. Can we check this feature?
Can I correct PR? I rebased firstly after that I changed the PR. But I get error in workflow. I don't know. |
I merged main and moved the error message to task log instead, since the HTTP response string can be potentially long and not belong to the exception. |
Hi,
This PR is about
Closes: #27029
I tested with local env and docker. I see that this result
P.S : I deleted my own Druid Broker host
Also I take pictures for standarts