Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Google Analytics tag version #27226

Merged
merged 3 commits into from
Oct 27, 2022
Merged

Fix Google Analytics tag version #27226

merged 3 commits into from
Oct 27, 2022

Conversation

oleg-ruban
Copy link
Contributor

@oleg-ruban oleg-ruban commented Oct 24, 2022

Closes: #27225 - Tracking User Activity Issue: Google Analytics tag version is not up-to-date #27225


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

fix bug apache#27225 - Tracking User Activity Issue: Google Analytics tag version is not up-to-date
apache#27225
@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Oct 24, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 24, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@eladkal eladkal changed the title Update google_analytics.html: fix bug #27225 - Tracking User Activity Issue: Google Analytics tag version is not up-to-date Fix Google Analytics tag version is not up-to-date Oct 24, 2022
@oleg-ruban oleg-ruban changed the title Fix Google Analytics tag version is not up-to-date Fix Google Analytics tag version Oct 25, 2022
Copy link
Contributor

@o-nikolas o-nikolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

It looks reasonable, but do we have any tests for this to verify it? Or at least some manual testing you can put in the description?

@oleg-ruban
Copy link
Contributor Author

Yes, I tested it manually by doing these changes in Airflow webserver running container and after that, I got metrics to Google Analytics.

@potiuk
Copy link
Member

potiuk commented Oct 26, 2022

Hmm. I thought we wanted to get rid of Analytics in favour of Matomo (which is far more privacy concerned and ASF supported).

apache/airflow-site#581 and apache/airflow-site#576

@rossturk - I think you were looking at it - is matomo working for our website ?

I guess we can remove anylytics completely ?

@rossturk
Copy link
Contributor

rossturk commented Oct 26, 2022

Correct - Matomo is gathering analytics for the Airflow website & docs, and they can be accessed unauthenticated via API or web @ analytics.apache.org. I think we can remove the GA tags completely 👍

@oleg-ruban if you are interested in doing so, that would be great! if not, I'd be happy to look into it.

@oleg-ruban
Copy link
Contributor Author

It might be better to expand the list of supported providers by adding Matomo without getting rid of Google Analytics.
I assume that it is the end user's responsibility to choose suited providers.

@potiuk
Copy link
Member

potiuk commented Oct 27, 2022

It might be better to expand the list of supported providers by adding Matomo without getting rid of Google Analytics. I assume that it is the end user's responsibility to choose suited providers.

Ah. My mistake, stupid me. I was 100% sure this is snippet from Airflow website, not from Airflow webserver (stupid me - I was just reading another PR about airflow-site repo and mixed the two). Sorry for that - yeah . You are absolutely right this is up to user :)

@potiuk
Copy link
Member

potiuk commented Oct 27, 2022

Error unrelated (and fixed in main already)

@potiuk potiuk merged commit 5e6cec8 into apache:main Oct 27, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 27, 2022

Awesome work, congrats on your first merged pull request!

@ephraimbuddy ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking User Activity Issue: Google Analytics tag version is not up-to-date
5 participants