-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Google Analytics tag version #27226
Conversation
fix bug apache#27225 - Tracking User Activity Issue: Google Analytics tag version is not up-to-date apache#27225
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
It looks reasonable, but do we have any tests for this to verify it? Or at least some manual testing you can put in the description?
Yes, I tested it manually by doing these changes in Airflow webserver running container and after that, I got metrics to Google Analytics. |
Hmm. I thought we wanted to get rid of Analytics in favour of Matomo (which is far more privacy concerned and ASF supported). apache/airflow-site#581 and apache/airflow-site#576 @rossturk - I think you were looking at it - is matomo working for our website ? I guess we can remove anylytics completely ? |
Correct - Matomo is gathering analytics for the Airflow website & docs, and they can be accessed unauthenticated via API or web @ analytics.apache.org. I think we can remove the GA tags completely 👍 @oleg-ruban if you are interested in doing so, that would be great! if not, I'd be happy to look into it. |
It might be better to expand the list of supported providers by adding Matomo without getting rid of Google Analytics. |
Ah. My mistake, stupid me. I was 100% sure this is snippet from Airflow website, not from Airflow webserver (stupid me - I was just reading another PR about airflow-site repo and mixed the two). Sorry for that - yeah . You are absolutely right this is up to user :) |
Error unrelated (and fixed in main already) |
Awesome work, congrats on your first merged pull request! |
Closes: #27225 - Tracking User Activity Issue: Google Analytics tag version is not up-to-date #27225
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.