Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix condition for k8 container completion check #27502

Closed
wants to merge 3 commits into from
Closed

Fix condition for k8 container completion check #27502

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d5102b7
Fix condition for k8 container completion check
Nov 4, 2022
56766c0
Extend pod tests
Nov 7, 2022
c3526f8
Add doc string to await_container_completion
Nov 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airflow/providers/cncf/kubernetes/utils/pod_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ def consume_logs(*, since_time: DateTime | None = None, follow: bool = True) ->
time.sleep(1)

def await_container_completion(self, pod: V1Pod, container_name: str) -> None:
while not self.container_is_running(pod=pod, container_name=container_name):
while self.container_is_running(pod=pod, container_name=container_name):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same fix was suggest and merged in #23883 but It was reverted in #24479
so just trying the same thing again is probably not going to work?
cc @akakakakakaa as the original author

Copy link
Author

@windmark windmark Nov 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks, yeah I'm aware. I opened this PR as a Draft (but wasn't aware that still pinged anyone) to see if I could run the CI tests.

The original PR was reverted due to failing tests, but unfortunately the CI logs and the slack conversations have both fallen victim to the retention. I'm still figuring out the testing flow locally but haven't found any failing tests yet, so must be missing something (as a new contributor).

time.sleep(1)

def await_pod_completion(self, pod: V1Pod) -> V1Pod:
Expand Down