Improve task_id to pod name conversion #27524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
provider:cncf-kubernetes
|
failures :( |
uranusjr
approved these changes
Nov 7, 2022
uranusjr
reviewed
Nov 7, 2022
jedcunningham
approved these changes
Nov 7, 2022
dstandish
force-pushed
the
improve-task-id-to-pod-name
branch
from
c77b558
to
4481c90
Compare
There are a few rules for pod names that we have to handle. See here: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/. One rule is must start and end with alphanumeric. Another is only alphanum, dot, -, and lowercase. Finally, no more than 253 chars. I added tests for the new behavior but also some incidental (perhaps surprising) other behavior namely the way that adding random suffix actually truncates the given pod name substantially.
dstandish
force-pushed
the
improve-task-id-to-pod-name
branch
from
4481c90
to
3c9ede0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few rules for pod names that we have to handle. See here: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/.
One rule is must start and end with alphanumeric. Another is only alphanum, dot, -, and lowercase. Finally, no more than 253 chars.
I added tests for the new behavior but also some incidental (perhaps surprising) other behavior namely the way that adding random suffix actually truncates the given pod name substantially.