Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix show user info error #27537

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Fix show user info error #27537

merged 1 commit into from
Nov 8, 2022

Conversation

chyok
Copy link
Contributor

@chyok chyok commented Nov 7, 2022

Hi,
closes: #27479

I found that this code will permanently delete the userinfoedit key in the context of the entire process
widgets['show'].template_args['actions'].pop('userinfoedit')
In fact, it will affect self.actions so the next deletion will be reported key error.

An interesting phenomenon is that when you refresh the page, there is a certain probability of success, but the number of successes will not exceed the number of your workers, because the "actions" of each process are affected.

setting a default value can solve this problem.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Nov 7, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 7, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Contributor

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chyok for the PR. Just to understand were you able to consistently reproduce this?

@chyok
Copy link
Contributor Author

chyok commented Nov 8, 2022

Thanks @chyok for the PR. Just to understand were you able to consistently reproduce this?

Yes, it is very easy to reproduce.
Security ->List Users ->show record and refresh several times will appear.

@potiuk
Copy link
Member

potiuk commented Nov 8, 2022

Nice!

@potiuk potiuk merged commit 6434b57 into apache:main Nov 8, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 8, 2022

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webserver add role to an existing user -> KeyError: 'userinfoedit'
5 participants