-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename hook bigquery function _bq_cast
to bq_cast
#27543
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we decide to make this function public, I also wonder if it’d be a good idea to move the function to somewhere in utils
instead.
I was not able to find the right place to add it to utils. shall I create |
Maybe |
for this PR scope, I'll be in favour of keeping it in |
4dbc9ea
to
ab5894a
Compare
Recently, I have started using hook bigquery function
_bq_cast
but I'm afraid that this might get changed silently since it is a private function so I want to rename it tobq_cast
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.