Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ipc_mode for DockerOperator #27553

Merged
merged 3 commits into from
Nov 10, 2022
Merged

Conversation

mrk-andreev
Copy link
Contributor

Add ipc_mode to DockerOperator. IPC (POSIX/SysV IPC) namespace provides separation of named shared memory segments, semaphores and message queues (https://docs.docker.com/engine/reference/run/#ipc-settings---ipc).

ipc_mode (str) – Set the IPC mode for the container.
ref: https://docker-py.readthedocs.io/en/stable/containers.html

@boring-cyborg
Copy link

boring-cyborg bot commented Nov 8, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@uranusjr
Copy link
Member

uranusjr commented Nov 9, 2022

If tests don’t fail (I think they would), we’ll need a new test for this.

@potiuk
Copy link
Member

potiuk commented Nov 9, 2022

They did fail :)

@potiuk
Copy link
Member

potiuk commented Nov 9, 2022

So need to be fixed @mrk-andreev

@mrk-andreev
Copy link
Contributor Author

Fixed

@potiuk potiuk merged commit a504a82 into apache:main Nov 10, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 10, 2022

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants