Avoid re-fetching DAG run in TriggerDagRunOperator #27635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and scheduled dag_run
… and scheduled dag_run
boring-cyborg
bot
added
area:API
Adityamalik123
requested review from
mik-laj and
ephraimbuddy
as code owners
uranusjr
approved these changes
Nov 14, 2022
ephraimbuddy
approved these changes
Nov 14, 2022
uranusjr
changed the title
|
Awesome work, congrats on your first merged pull request! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to fix
TriggerDagRunOperatorwhen passed following:reset_dag_run=Trueexecution_date=SomeDateandtrigger_run_id = **None**The current code considers DagRunType 'MANUAL' by default in case
trigger_run_idis None. As mentioned in this issue [https://github.com//issues/27299], There can be a case where we can have DagRunType 'SCHEDULED' with the similar scenario.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.