Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

listener plugin example added #27905

Merged
merged 1 commit into from
Jan 20, 2023
Merged

listener plugin example added #27905

merged 1 commit into from
Jan 20, 2023

Conversation

Bowrna
Copy link
Contributor

@Bowrna Bowrna commented Nov 25, 2022

related: #15353

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@Bowrna Bowrna force-pushed the new_listener_plugin_example branch 4 times, most recently from b3d8e6f to dec5788 Compare November 30, 2022 05:22
@Bowrna Bowrna marked this pull request as ready for review November 30, 2022 05:24
@Bowrna Bowrna requested a review from potiuk as a code owner November 30, 2022 05:24
@Bowrna Bowrna force-pushed the new_listener_plugin_example branch 3 times, most recently from 25d8b97 to bec29d9 Compare November 30, 2022 11:17
@Bowrna
Copy link
Contributor Author

Bowrna commented Nov 30, 2022

CI pipeline tests are failing in Sqlite tests. I didn't add anything relevant to that. Could anyone help me why its occurring?

@potiuk
Copy link
Member

potiuk commented Dec 4, 2022

We have some more than usual instability in sqlite tests. I am not sure why - but I will take a look shortly.

@Bowrna
Copy link
Contributor Author

Bowrna commented Dec 5, 2022

If there is anything that I have to improve in this example, with regard to recent Airflow 2.5 release let me know. I will see if I can improve it further.
@kaxil @potiuk

@kaxil
Copy link
Member

kaxil commented Dec 5, 2022

If there is anything that I have to improve in this example, with regard to recent Airflow 2.5 release let me know. I will see if I can improve it further. @kaxil @potiuk

We should add an example for DAG listener too if it doesn't exist -- can be a separate PR too.

It was added in 035315f#diff-78d2fef5ef9818cef722ba4ae1f35c66cebfcb73c33a7d4dfda1db23009599e0R24

@Bowrna
Copy link
Contributor Author

Bowrna commented Dec 6, 2022 •
edited

yes I will add it as a separate PR @kaxil

Edit: I think it makes sense to include DAG listener part also as part of this PR. I will make the change this weekend.

@Bowrna Bowrna closed this Dec 8, 2022
@Bowrna Bowrna reopened this Dec 8, 2022
@Bowrna Bowrna force-pushed the new_listener_plugin_example branch 3 times, most recently from 20f9b5e to 9eefe7f Compare December 11, 2022 13:38
@Bowrna Bowrna requested a review from mik-laj as a code owner December 11, 2022 13:38
@Bowrna
Copy link
Contributor Author

Bowrna commented Dec 11, 2022

Failing in Postgres-related static check (test related to Kubernetes). I didn't make changes that will fail the test.

@Bowrna
Copy link
Contributor Author

Bowrna commented Dec 13, 2022

@kaxil I have added the dag listeners part too in this code. Verify when you get time. Thanks.

@Bowrna
Copy link
Contributor Author

Bowrna commented Dec 21, 2022

is there anything that needs to be done to get this PR merged?

@Bowrna
Copy link
Contributor Author

Bowrna commented Jan 7, 2023

Hello :) Do I have any update on this PR? I am looking forward to get this code merged.

@Bowrna Bowrna force-pushed the new_listener_plugin_example branch 3 times, most recently from b37a3ca to aee67a8 Compare January 8, 2023 10:34
@kaxil kaxil force-pushed the new_listener_plugin_example branch from aee67a8 to 7eb86d3 Compare January 9, 2023 20:56
@kaxil kaxil assigned dstandish and unassigned dstandish Jan 9, 2023
@kaxil kaxil requested a review from dstandish January 9, 2023 20:58
@Bowrna Bowrna force-pushed the new_listener_plugin_example branch from 82e9033 to fb4ab9e Compare January 10, 2023 01:48
@potiuk
Copy link
Member

potiuk commented Jan 18, 2023

Nice one ! @kaxil ?

@potiuk potiuk merged commit 100bb8d into apache:main Jan 20, 2023
maggesssss pushed a commit to maggesssss/airflow that referenced this pull request Jan 21, 2023
@Bowrna @maggesssss
listener plugin example added (apache#27905)
8250a1c
@pierrejeambrun pierrejeambrun added the type:doc-only Changelog: Doc Only label Feb 27, 2023
@pierrejeambrun pierrejeambrun added this to the Airflow 2.5.2 milestone Feb 27, 2023
pierrejeambrun pushed a commit that referenced this pull request Mar 6, 2023
@Bowrna @pierrejeambrun
listener plugin example added (#27905)
1456f11 
(cherry picked from commit 100bb8d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaxil kaxil kaxil left review comments

@potiuk potiuk potiuk approved these changes

@mik-laj mik-laj Awaiting requested review from mik-laj

@dstandish dstandish Awaiting requested review from dstandish

Assignees
No one assigned
Labels
type:doc-only Changelog: Doc Only
Projects
None yet
Milestone
Airflow 2.5.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Bowrna @potiuk @kaxil @pierrejeambrun @dstandish