Fix selective checks handling error tracebacks in CI #28514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
force-pushed
the
fix-selective-check-handling-traceback
branch
from
de978dc
to
eb7902b
Compare
Initially selective check was implemented in the way that it printed diagnostic output on stdout and the GITHUB_OUTPUT compatible set of outputs on stderr so that it could be redirected to the GITHUB_OUTPUT in its entirety. But this turned out to be a bad idea because when there was an error generated in selective-checks themselves, the traceback was printed in stderr and redirecting stderr to GITHUB_OUTPUT swallowed the traceback. This change reverses the behaviour: * diagnostic output is printed to stderr * GITHUB_OUTPUT compatible output is printed to stdout This way when traceback happens it is printed to stderr and is not swalleowed by redirection to GITHUB_OUTPUT
potiuk
force-pushed
the
fix-selective-check-handling-traceback
branch
from
eb7902b
to
6719a53
Compare
xinbinhuang
approved these changes
Dec 21, 2022
jedcunningham
approved these changes
Dec 21, 2022
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Dec 21, 2022
The apache#28514 added traceback handling for selective checks but the redirection had not been fixed in few other workflows where it was used.
potiuk
added a commit
that referenced
this pull request
Dec 21, 2022
The #28514 added traceback handling for selective checks but the redirection had not been fixed in few other workflows where it was used.
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 12, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 12, 2023
Initially selective check was implemented in the way that it printed diagnostic output on stdout and the GITHUB_OUTPUT compatible set of outputs on stderr so that it could be redirected to the GITHUB_OUTPUT in its entirety. But this turned out to be a bad idea because when there was an error generated in selective-checks themselves, the traceback was printed in stderr and redirecting stderr to GITHUB_OUTPUT swallowed the traceback. This change reverses the behaviour: * diagnostic output is printed to stderr * GITHUB_OUTPUT compatible output is printed to stdout This way when traceback happens it is printed to stderr and is not swalleowed by redirection to GITHUB_OUTPUT (cherry picked from commit bc7feda)
84 tasks
86 tasks
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Feb 6, 2023
The apache#28514 change added capability of getting trace errors for the command by swapping redirection of stderr and stdout, but debug output for github_output file remoined in stderr. This was no problem in most cases as rich did not produce color codes for stderr redirection and github_output was able to parse it properly - and each line in the GITHHUB_OUTPUT was simply duplicated. However, when number of labels was big, rich split the message and it caused Invalid format message.
potiuk
added a commit
that referenced
this pull request
Feb 6, 2023
The #28514 change added capability of getting trace errors for the command by swapping redirection of stderr and stdout, but debug output for github_output file remoined in stderr. This was no problem in most cases as rich did not produce color codes for stderr redirection and github_output was able to parse it properly - and each line in the GITHHUB_OUTPUT was simply duplicated. However, when number of labels was big, rich split the message and it caused Invalid format message.
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 7, 2023
The #28514 change added capability of getting trace errors for the command by swapping redirection of stderr and stdout, but debug output for github_output file remoined in stderr. This was no problem in most cases as rich did not produce color codes for stderr redirection and github_output was able to parse it properly - and each line in the GITHHUB_OUTPUT was simply duplicated. However, when number of labels was big, rich split the message and it caused Invalid format message. (cherry picked from commit 9f1f026)
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 8, 2023
The #28514 change added capability of getting trace errors for the command by swapping redirection of stderr and stdout, but debug output for github_output file remoined in stderr. This was no problem in most cases as rich did not produce color codes for stderr redirection and github_output was able to parse it properly - and each line in the GITHHUB_OUTPUT was simply duplicated. However, when number of labels was big, rich split the message and it caused Invalid format message. (cherry picked from commit 9f1f026)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially selective check was implemented in the way that it printed diagnostic output on stdout and the GITHUB_OUTPUT compatible set of outputs on stderr so that it could be redirected to the GITHUB_OUTPUT in its entirety. But this turned out to be a bad idea because when there was an error generated in selective-checks themselves, the traceback was printed in stderr and redirecting stderr to GITHUB_OUTPUT swallowed the traceback.
This change reverses the behaviour:
This way when traceback happens it is printed to stderr and is not swalleowed by redirection to GITHUB_OUTPUT
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.