Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose updated_at filter for dag run and task instance endpoints #28636

Merged
merged 5 commits into from
Feb 2, 2023
Merged

Expose updated_at filter for dag run and task instance endpoints #28636

merged 5 commits into from
Feb 2, 2023

Conversation

Adityamalik123
Copy link
Contributor

@Adityamalik123 Adityamalik123 commented Dec 28, 2022 •
edited
Loading

We need to expose updated_at filter for dag run and task instance endpoints Ref: #27782

@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Dec 28, 2022
@Adityamalik123 Adityamalik123 changed the title Adding base changes for adding updated_at filter for task_instance_en… Expose updated_at filter for dag run and task instance endpoints Dec 28, 2022
@Adityamalik123 Adityamalik123 marked this pull request as ready for review December 28, 2022 21:25
@Adityamalik123 Adityamalik123 marked this pull request as draft December 28, 2022 21:25
@vincbeck
Copy link
Contributor

vincbeck commented Jan 9, 2023

@Adityamalik123 Are you still working on it? The solution looks good and you got approvals soI think you can "open" the PR. It is currently in draft

@Adityamalik123
Copy link
Contributor Author

@Adityamalik123 Are you still working on it? The solution looks good and you got approvals soI think you can "open" the PR. It is currently in draft

@vincbeck I have to add the similar set of filters for dag run endpoint as well, the current PR only has it task instance endpoint. I'll push the changes for it today and then mark it ready for review.

@vincbeck
Copy link
Contributor

Hey @Adityamalik123. Just following up on this one, any news?

@Adityamalik123 Adityamalik123 force-pushed the issue-27782 branch 2 times, most recently from cd605c2 to 302fca0 Compare January 24, 2023 15:18
@Adityamalik123 Adityamalik123 marked this pull request as ready for review January 27, 2023 11:28
@Adityamalik123
Copy link
Contributor Author

Adityamalik123 commented Jan 27, 2023 •
edited
Loading

Hey @Adityamalik123. Just following up on this one, any news?

@vincbeck Apologies for the delay. I have made the relevant changes and marked the PR ready for review.

@vincbeck
Copy link
Contributor

Hey @Adityamalik123. Just following up on this one, any news?

@vincbeck Apologies for the delay. I have made the relevant changes and marked the PR ready for review.

No worries at all! LGTM!

@bbovenzi bbovenzi merged commit 478fd82 into apache:main Feb 2, 2023
@pierrejeambrun pierrejeambrun added this to the Airflow 2.6.0 milestone Feb 27, 2023
@pierrejeambrun pierrejeambrun added the type:improvement Changelog: Improvements label Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uranusjr uranusjr uranusjr approved these changes

@bbovenzi bbovenzi bbovenzi approved these changes

@vincbeck vincbeck vincbeck approved these changes

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

Assignees
No one assigned
Labels
area:API Airflow's REST/HTTP API type:improvement Changelog: Improvements
Projects
None yet
Milestone
Airflow 2.6.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Adityamalik123 @vincbeck @uranusjr @ephraimbuddy @bbovenzi @pierrejeambrun