Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs introduced when moving the code of issue generation to breeze #28683

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jan 2, 2023

The #28352 introduced subtle bugs which failed when runnint it during provider generation.

Also added running the command automatically in CI.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk
Copy link
Member Author

potiuk commented Jan 2, 2023

Let's see if it will work :)

The apache#28352 introduced subtle bugs which failed when runnint it during
provider generation.

Also added running the command automatically in CI.
@potiuk potiuk force-pushed the fix-bugs-introduced-in-migrating-issue-generation-command branch from 65f5993 to f132493 Compare January 2, 2023 18:13
@potiuk
Copy link
Member Author

potiuk commented Jan 2, 2023

Also added a flag to remove progress - it was producing far too long log in CI

@potiuk potiuk merged commit 69ab7d8 into apache:main Jan 2, 2023
@potiuk potiuk deleted the fix-bugs-introduced-in-migrating-issue-generation-command branch January 2, 2023 18:59
ephraimbuddy pushed a commit that referenced this pull request Mar 8, 2023
#28683)

The #28352 introduced subtle bugs which failed when runnint it during
provider generation.

Also added running the command automatically in CI.

(cherry picked from commit 69ab7d8)
ephraimbuddy pushed a commit that referenced this pull request Mar 9, 2023
#28683)

The #28352 introduced subtle bugs which failed when runnint it during
provider generation.

Also added running the command automatically in CI.

(cherry picked from commit 69ab7d8)
ephraimbuddy pushed a commit that referenced this pull request Mar 10, 2023
#28683)

The #28352 introduced subtle bugs which failed when runnint it during
provider generation.

Also added running the command automatically in CI.

(cherry picked from commit 69ab7d8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants