Add correct widgets in Docker Hook #28700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change refactored DockerHook and by mistake it missed the propoer widget specification. For some reason the tests did not catch it (to be investigated) but this should fix the failing tests.
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jan 3, 2023
Those tests are running various tests with Providers Manager and could catch errors introduced by provider-only changes so they should be added to "Always" tests to be "always" run in our CI. Skipping this test was the main reason why apache#28700 change was needed after the apache#28363 was merged.
jedcunningham
approved these changes
Jan 3, 2023
|
Thanks @jedcunningham ! |
37 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change #28363 refactored DockerHook and by mistake it missed the
propoer widget specification. For some reason the tests did not
catch it (to be investigated) but this should fix the failing
tests.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.