Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FixGoogleCampaignManagerReportSensor with QUEUED status #28735

Merged
merged 1 commit into from Jan 9, 2023
Merged

FixGoogleCampaignManagerReportSensor with QUEUED status #28735

merged 1 commit into from Jan 9, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jan 4, 2023

Google Campaign Manager 360, in their latest api version (v4), introduced a new status that a report file can return. As v4 is the only version that is currently supported, we should update the sensor to work well with these changes.

Currently, sensor only checks if file status is different from PROCESSING. As You can see in the official documentation there is a status called QUEUED which also means that the report file is not yet picked up for processing. From my experience this status can be returned when API is globally under heavy load or if You are generating multiple reports at once as a single user. Right now sensor exits when finding QUEUED status:
image
and it should wait for the file to be processed.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@ghost ghost requested a review from turbaszek as a code owner January 4, 2023 17:54
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Jan 4, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 4, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@eladkal eladkal changed the title Change pool of processing statuses of Campaign Manager report FixGoogleCampaignManagerReportSensor with QUEUED state Jan 9, 2023
@eladkal eladkal changed the title FixGoogleCampaignManagerReportSensor with QUEUED state FixGoogleCampaignManagerReportSensor with QUEUED status Jan 9, 2023
@eladkal eladkal merged commit 71306b3 into apache:main Jan 9, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 9, 2023

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant