Fix Incorrect await_container_completion
#28771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix the corresponding test that fails once we make this fix
boring-cyborg
bot
added
provider:cncf-kubernetes
|
After this gets merged, i'll be able to recreate #28752 (based off this in main) |
uranusjr
reviewed
Jan 6, 2023
uranusjr
approved these changes
Jan 6, 2023
jedcunningham
approved these changes
Jan 6, 2023
eladkal
changed the title
await_container_completion in KubernetesPodOperator
eladkal
changed the title
await_container_completion in KubernetesPodOperatorawait_container_completion in PodManager
eladkal
changed the title
await_container_completion in PodManagerawait_container_completion
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix the corresponding test that fails once we make this fix.
This is a split up of #28752
Closes #26796