Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dep context description for better log message #28875

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Add dep context description for better log message #28875

merged 1 commit into from
Jan 12, 2023

Conversation

dstandish
Copy link
Contributor

@dstandish dstandish commented Jan 12, 2023 •
edited

Otherwise, it appears as though there is a duplicate log record (which there isn't -- it's just called twice)

After:

[2023-01-12, 06:08:10 UTC] {taskinstance.py:1120} INFO - Dependencies all met for dep_context=non-requeueable deps ti=<TaskInstance: example_time_delta_sensor_async.wait manual__2023-01-12T06:07:28.079404+00:00 [queued]>
[2023-01-12, 06:08:10 UTC] {taskinstance.py:1120} INFO - Dependencies all met for dep_context=requeueable deps ti=<TaskInstance: example_time_delta_sensor_async.wait manual__2023-01-12T06:07:28.079404+00:00 [queued]>

@dstandish
Add dep context description for better log message
7cbc95a 
Otherwise, it appears that there is a duplicate log record.
@uranusjr
Copy link
Member

Do we not want to include other DepContext fields in the log?

@dstandish
Copy link
Contributor Author

Do we not want to include other DepContext fields in the log?

too many values. i explored mucking with repr to just print out non-default values but ... was a pain so i thought this good enough improvement

@dstandish dstandish merged commit 1ca94ee into apache:main Jan 12, 2023
@dstandish dstandish deleted the dep-context-log-message-helpful branch January 12, 2023 07:56
@pierrejeambrun pierrejeambrun added this to the Airflow 2.5.2 milestone Feb 27, 2023
@pierrejeambrun pierrejeambrun added the type:misc/internal Changelog: Misc changes that should appear in change log label Feb 27, 2023
pierrejeambrun pushed a commit that referenced this pull request Mar 6, 2023
@dstandish @pierrejeambrun
Add dep context description for better log message (#28875)
8719079 
Otherwise, it appears that there is a duplicate log record.

(cherry picked from commit 1ca94ee)
pierrejeambrun pushed a commit that referenced this pull request Mar 8, 2023
@dstandish @pierrejeambrun
Add dep context description for better log message (#28875)
43c9359 
Otherwise, it appears that there is a duplicate log record.

(cherry picked from commit 1ca94ee)
@pierrejeambrun pierrejeambrun mentioned this pull request Mar 10, 2023
Closed
64 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uranusjr uranusjr uranusjr approved these changes

@kaxil kaxil Awaiting requested review from kaxil kaxil is a code owner

@XD-DENG XD-DENG Awaiting requested review from XD-DENG XD-DENG is a code owner

@ashb ashb Awaiting requested review from ashb ashb is a code owner

Assignees
No one assigned
Labels
type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Milestone
Airflow 2.5.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dstandish @uranusjr @pierrejeambrun