Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove conn.close() ignores #29005

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Conversation

uranusjr
Copy link
Member

Continuation of #28995

@uranusjr
Copy link
Member Author

Uh… this works?

@uranusjr uranusjr marked this pull request as ready for review January 18, 2023 08:12
@uranusjr uranusjr merged commit 85f8df7 into apache:main Jan 18, 2023
@uranusjr uranusjr deleted the types-mysql-to-hive branch January 18, 2023 10:12
@potiuk
Copy link
Member

potiuk commented Jan 18, 2023

This worked accidentally. I believe you broke all people's PRs this way. Constraints were not yet refreshed when you merged and you used old version of mysql-connector-python in this PR.

potiuk added a commit to potiuk/airflow that referenced this pull request Jan 18, 2023
@potiuk
Copy link
Member

potiuk commented Jan 18, 2023

#29010 reverts it for now.

Some more context:

The thing with constraints is that they require a successful main build to get refreshed. This can take anything between 30 minutes up to several hours (depending on subsequent merges - if you merge several commits one after another, they will cancel running "main" builds and it might take multiple hours undil the main "green" build refresh the constraints.

Until then all regular PRs (like this one) which do not change setup.py or provider.yaml are using old constraitns.

@potiuk
Copy link
Member

potiuk commented Jan 18, 2023

The status of constraints refresh can be tracked here @uranusjr: https://github.com/apache/airflow/commits/constraints-main and once it gets refresh you will be able to re-attempt to fix the exclusions :)

potiuk added a commit that referenced this pull request Jan 18, 2023
@potiuk
Copy link
Member

potiuk commented Jan 18, 2023

This could be retried now: 5ec488f as constraints got updated (and mysql-connector-python is updated).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants