Remove upper bound limitation for pytest

[auvipy]

An attempt to update pytest version limit

[Taragolis]

I think if main idea remove upper bound limitations and better use pytest>=6.0 or pytest>=7.0 (if we intend to use features which added only in 7.0 branch)

Maybe it is not a case of pytest.

[auvipy]

make sense, done

[Taragolis]

I have a look at the warning logs, It is very hard to find where actually it raised. But finally I found only one type of pytest-specific warning.

When we won't expected any warnings in test case we use

with pytest.warns(None):
    ...

But we should: https://docs.pytest.org/en/latest/how-to/capture-warnings.html#additional-use-cases-of-warnings-in-tests

with warnings.catch_warnings():
    warnings.simplefilter("error")
    ...

We should do this as follow up however I have a suspicion that recommended solution wouldn't work because pytest-capture-warnings suppress this errored-warning, see: #28590 (comment)

[Taragolis]

@auvipy could you also remove this upper bound limitation

airflow/setup.py

Lines 395 to 397 in 245c4e3

	# We should attempt to remove the limit when we upgrade Pytest
	# TODO: remove the limit when we upgrade pytest
	"pytest-rerunfailures~=9.1",

I think we use it because version 10 required pytest 7+

[auvipy]

yes of course, thanks for pointing

[potiuk]

NIce. Seems like everything works fine. Test seems to be executing and succeeding, I see not even yellow flags. Pytest is upgraded in the image:

All looks good.

[potiuk]

(pending removal of rerun plugin upper-bound limit of course)

[auvipy]

ok will do that

[Taragolis]

ok will do that

Also need remove redundant comments that we need to migrate.

[auvipy]

ok will clear the comments as well

[auvipy]

done with review comments

[Taragolis]

Non relevant error in the CI to this PR. Looks like internal_api test flaky

            if not ignore_running:
                raise AssertionError(
>                   "Background processes are running that prevent the test from passing successfully."
                )
E               AssertionError: Background processes are running that prevent the test from passing successfully.

tests/cli/commands/test_internal_api_command.py:112: AssertionError

[Taragolis]

👍

[auvipy]

I think we can handle that in another PR?

[Taragolis]

I think we can handle that in another PR?

It definitely for another PR and related only to AIP-44, this flaky error also appeared in pytest 6 yesterday.

[auvipy]

thank you both