Fix to run tasks on Dask Worker for Windows systems #29107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casra-developers
requested review from
kaxil,
ashb and
XD-DENG
as code owners
potiuk
approved these changes
Jan 23, 2023
|
Agree - not a problem to have it in. Marked it as "2.5.2" so when we release it, you won't have to patch it. |
|
@potiuk Glad to hear it, thank you :) |
pierrejeambrun
changed the title
pierrejeambrun
changed the title
pierrejeambrun
changed the title
pierrejeambrun
changed the title
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 7, 2023
* Introduced fix to run tasks on Windows Co-authored-by: Dominik Werner <dwerner@casra.ch> (cherry picked from commit f8e8fc0)
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 8, 2023
* Introduced fix to run tasks on Windows Co-authored-by: Dominik Werner <dwerner@casra.ch> (cherry picked from commit f8e8fc0)
64 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for using Airflow module on Windows Dask Worker
In the latest release of Airflow (tested with 2.5.1), task execution on a Dask Worker will fail on Windows due to the usage of an unknown attribute from the signal module.
The offending line is located in airflow/jobs/local_task_job.py
In this PR we have not removed the line but simply put it in the scope of an IF condition that skips it if the constant IS_WINDOWS from airflow.utils.platform is True. This mitigates the issue and allows the Windows systems to be used as Dask Workers for Airflow.
Having Windows Workers for our Airflow Cluster is a very important use-case in our company, due to some legacy dependencies that still need to be supported. Others may find this useful, hence why we share this simple fix and propose to include the change that will have no effect on POSIX based systems.