Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix access to context in functions decorated by task.sensor #29146

Merged

Conversation

Thomas-McKanna
Copy link
Contributor

Previous implementation did not properly expose Airflow context in functions decorated by airflow.decorators.task.sensor:

def poke(self, context: Context) -> PokeReturnValue | bool:
return self.python_callable(*self.op_args, **self.op_kwargs)

Since DecoratedSensorOperator is a subclass of PythonSensor, I've removed the definition of poke so that the definition in PythonSensor is used:

def poke(self, context: Context) -> PokeReturnValue | bool:
context_merge(context, self.op_kwargs, templates_dict=self.templates_dict)
self.op_kwargs = determine_kwargs(self.python_callable, self.op_args, context)
self.log.info("Poking callable: %s", str(self.python_callable))
return_value = self.python_callable(*self.op_args, **self.op_kwargs)
if isinstance(return_value, PokeReturnValue):
return return_value
else:
return PokeReturnValue(bool(return_value))

closes: #29137

@boring-cyborg
Copy link

boring-cyborg bot commented Jan 25, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@eladkal eladkal added this to the Airflow 2.5.2 milestone Feb 18, 2023
@potiuk potiuk merged commit 2d3cc50 into apache:main Feb 20, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 20, 2023

Awesome work, congrats on your first merged pull request!

@pierrejeambrun pierrejeambrun added the type:new-feature Changelog: New Features label Feb 27, 2023
@pierrejeambrun pierrejeambrun added the type:bug-fix Changelog: Bug Fixes label Feb 27, 2023
@pierrejeambrun pierrejeambrun changed the title Add ability to access context in functions decorated by task.sensor Fix access context in functions decorated by task.sensor Feb 27, 2023
@pierrejeambrun pierrejeambrun changed the title Fix access context in functions decorated by task.sensor Fix access to context in functions decorated by task.sensor Feb 27, 2023
@pierrejeambrun pierrejeambrun removed the type:new-feature Changelog: New Features label Feb 27, 2023
pierrejeambrun pushed a commit that referenced this pull request Mar 7, 2023
Co-authored-by: Thomas McKanna <mail.thomasmckanna@gmail.com>
(cherry picked from commit 2d3cc50)
pierrejeambrun pushed a commit that referenced this pull request Mar 8, 2023
Co-authored-by: Thomas McKanna <mail.thomasmckanna@gmail.com>
(cherry picked from commit 2d3cc50)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix access to context in functions decorated by task.sensor
6 participants