Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pipeline.rst - Fix query in merge_data() task #29158

Merged
merged 3 commits into from
Mar 8, 2023
Merged

Update pipeline.rst - Fix query in merge_data() task #29158

merged 3 commits into from
Mar 8, 2023

Conversation

tsoud
Copy link
Contributor

@tsoud tsoud commented Jan 25, 2023

The alias for the subquery was missing in the merge_data() function's query, so it just needed to be added. Otherwise, the employees table remains empty. I found the error in the postgres container logs:

2023-01-25 08:00:03 2023-01-25 14:00:03.256 UTC [70428] ERROR:  subquery in FROM must have an alias at character 74
2023-01-25 08:00:03 2023-01-25 14:00:03.256 UTC [70428] HINT:  For example, FROM (SELECT ...) [AS] foo.
2023-01-25 08:00:03 2023-01-25 14:00:03.256 UTC [70428] STATEMENT:  
2023-01-25 08:00:03                 INSERT INTO employees
2023-01-25 08:00:03                 SELECT *
2023-01-25 08:00:03                 FROM (
2023-01-25 08:00:03                     SELECT DISTINCT *
2023-01-25 08:00:03                     FROM employees_temp
2023-01-25 08:00:03                 )
2023-01-25 08:00:03                 ON CONFLICT ("Serial Number") DO UPDATE
2023-01-25 08:00:03                 SET "Serial Number" = excluded."Serial Number";

Thank you!


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

The alias for the subquery was missing in the `merge_data()` function's query, so it just needed to be added. Otherwise, the `employees` table remains empty. I found the error in the postgres container logs:
```
2023-01-25 08:00:03 2023-01-25 14:00:03.256 UTC [70428] ERROR:  subquery in FROM must have an alias at character 74
2023-01-25 08:00:03 2023-01-25 14:00:03.256 UTC [70428] HINT:  For example, FROM (SELECT ...) [AS] foo.
2023-01-25 08:00:03 2023-01-25 14:00:03.256 UTC [70428] STATEMENT:  
2023-01-25 08:00:03                 INSERT INTO employees
2023-01-25 08:00:03                 SELECT *
2023-01-25 08:00:03                 FROM (
2023-01-25 08:00:03                     SELECT DISTINCT *
2023-01-25 08:00:03                     FROM employees_temp
2023-01-25 08:00:03                 )
2023-01-25 08:00:03                 ON CONFLICT ("Serial Number") DO UPDATE
2023-01-25 08:00:03                 SET "Serial Number" = excluded."Serial Number";
```

Thank you!
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 25, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Contributor

@josh-fell josh-fell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue with the merge SQL looks to be fixed with the 2.5.1 tutorial. The example is not practical to begin with though. Better to change it.

docs/apache-airflow/tutorial/pipeline.rst Outdated Show resolved Hide resolved
tsoud and others added 2 commits March 7, 2023 17:54
Co-authored-by: Josh Fell <48934154+josh-fell@users.noreply.github.com>
@josh-fell josh-fell merged commit 0d3d0e2 into apache:main Mar 8, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 8, 2023

Awesome work, congrats on your first merged pull request!

@josh-fell
Copy link
Contributor

@tsoud Congrats on your first contribution! 🎉

@eladkal eladkal added this to the Airflow 2.5.2 milestone Mar 8, 2023
@eladkal eladkal added the type:doc-only Changelog: Doc Only label Mar 8, 2023
pierrejeambrun pushed a commit that referenced this pull request Mar 8, 2023
* Update pipeline.rst - Fix query in `merge_data()` task

The alias for the subquery was missing in the `merge_data()` function's query, so it just needed to be added. Otherwise, the `employees` table remains empty. I found the error in the postgres container logs:
```
2023-01-25 08:00:03 2023-01-25 14:00:03.256 UTC [70428] ERROR:  subquery in FROM must have an alias at character 74
2023-01-25 08:00:03 2023-01-25 14:00:03.256 UTC [70428] HINT:  For example, FROM (SELECT ...) [AS] foo.
2023-01-25 08:00:03 2023-01-25 14:00:03.256 UTC [70428] STATEMENT:
2023-01-25 08:00:03                 INSERT INTO employees
2023-01-25 08:00:03                 SELECT *
2023-01-25 08:00:03                 FROM (
2023-01-25 08:00:03                     SELECT DISTINCT *
2023-01-25 08:00:03                     FROM employees_temp
2023-01-25 08:00:03                 )
2023-01-25 08:00:03                 ON CONFLICT ("Serial Number") DO UPDATE
2023-01-25 08:00:03                 SET "Serial Number" = excluded."Serial Number";
```

Thank you!

* Update docs/apache-airflow/tutorial/pipeline.rst

Co-authored-by: Josh Fell <48934154+josh-fell@users.noreply.github.com>

---------

Co-authored-by: Josh Fell <48934154+josh-fell@users.noreply.github.com>
(cherry picked from commit 0d3d0e2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants