Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trigger process to Airflow Docker docs #29203

Merged
merged 2 commits into from
Jan 30, 2023

Conversation

amarlearning
Copy link
Contributor

closes: #29150

@boring-cyborg
Copy link

boring-cyborg bot commented Jan 27, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. It is also future-proof

@potiuk potiuk requested a review from Taragolis January 29, 2023 11:17
Technically the triggerer does not necessarily run an asyncio loop.
@uranusjr uranusjr changed the title docs: Add trigger process missing from Airflow docker Add trigger process to Airflow Docker docs Jan 30, 2023
@uranusjr uranusjr merged commit 272f358 into apache:main Jan 30, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 30, 2023

Awesome work, congrats on your first merged pull request!

@pierrejeambrun pierrejeambrun added this to the Airflow 2.5.2 milestone Feb 27, 2023
@pierrejeambrun pierrejeambrun added the type:doc-only Changelog: Doc Only label Feb 27, 2023
pierrejeambrun pushed a commit that referenced this pull request Mar 7, 2023
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
(cherry picked from commit 272f358)
pierrejeambrun pushed a commit that referenced this pull request Mar 8, 2023
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
(cherry picked from commit 272f358)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trigger process missing from Airflow docker docs
5 participants