Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update google cloud dlp package and adjust hook and operators #29234

Merged
merged 4 commits into from
Feb 20, 2023

Conversation

lwyszomi
Copy link
Contributor


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Jan 30, 2023
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the change (and the fact that we are bumping the version. But we need a comment on why we are upper-binding the version (or remove the upper-binding)

@lwyszomi
Copy link
Contributor Author

@potiuk I removed upper-bound from requirements

@eladkal
Copy link
Contributor

eladkal commented Jan 30, 2023

static checks are failing

@lwyszomi
Copy link
Contributor Author

@eladkal @potiuk is it possible to merge this?

@lwyszomi
Copy link
Contributor Author

@eladkal @potiuk do you think now is everything ok with this?

Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@potiuk ?

@potiuk
Copy link
Member

potiuk commented Feb 20, 2023

Let me just rebase - just in case - I think the failures were intermittent, but just want to double-check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants