Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#29353) feat: TableauOperator.template_fields = find, match_with #29360

Merged
merged 10 commits into from Feb 3, 2023

Conversation

seunggabi
Copy link
Contributor

related: #29353


I want to use dag params on TableauOperator. So, I suggest this code.

as-is

task_refresh_workbook_blocking = TableauOperator(
    resource="workbooks",
    method="refresh",
    match_with="id",
    find="MyWorkbook",
    blocking_refresh=True,
    task_id="refresh_tableau_workbook_blocking",
    dag=dag,
)

to-be

task_refresh_workbook_blocking = TableauOperator(
    resource="workbooks",
    method="refresh",
    match_with="{{ params.match_with }}",
    find="{{ params.find }}",
    blocking_refresh=True,
    task_id="refresh_tableau_workbook_blocking",
    dag=dag,
)

Please check this pr.
THX very much.

@josh-fell josh-fell merged commit 67b92d7 into apache:main Feb 3, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 3, 2023

Awesome work, congrats on your first merged pull request!

@josh-fell
Copy link
Contributor

@seunggabi Congrats on your first contribution! 🎉

@seunggabi seunggabi deleted the feature/#29353_tableau-operator branch February 4, 2023 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants