Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve health checks in example docker-compose and clarify usage #29408

Merged
merged 3 commits into from
Feb 15, 2023
Merged

Improve health checks in example docker-compose and clarify usage #29408

merged 3 commits into from
Feb 15, 2023

Conversation

Taragolis
Copy link
Contributor

This PR include some improvements and clarifications:

  • Based on my experience use simple http scheduler healthcheck required less resources rather run in shell airflow cli.
  • Added grace period for healthchecks, which also reduce resource usage during startup airflow services
  • Increase healthchecks intervals, for the same reason - reduce resource usage.
  • Set port mapping as string
  • Added clarification about _PIP_ADDITIONAL_REQUIREMENTS, users might ignore warning during services startup however they should noticed it when add modification in docker-compose.yml

@Taragolis Taragolis force-pushed the docker-compose-change-example branch from 0105d36 to 30674a5 Compare February 8, 2023 06:01
@Taragolis Taragolis force-pushed the docker-compose-change-example branch from 30674a5 to 383b7b4 Compare February 8, 2023 06:32
@potiuk
Copy link
Member

potiuk commented Feb 8, 2023

Tested it locally additionally. Looks good!

BasPH
BasPH reviewed Feb 8, 2023
View reviewed changes
Copy link
Contributor

@BasPH BasPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small rewording for clarity but otherwise looks good

docs/apache-airflow/howto/docker-compose/docker-compose.yaml Outdated Show resolved Hide resolved
Taragolis and others added 2 commits February 8, 2023 14:24
@Taragolis @BasPH
Apply suggestions from code review
4f30c96 
Co-authored-by: Bas Harenslak <BasPH@users.noreply.github.com>
@Taragolis
fix static checks
649c4dd
@Taragolis Taragolis merged commit 08bec93 into apache:main Feb 15, 2023
@Taragolis Taragolis deleted the docker-compose-change-example branch February 15, 2023 11:33
@Taragolis Taragolis mentioned this pull request Feb 20, 2023
Merged
Taragolis added a commit that referenced this pull request Feb 20, 2023
@Taragolis
Revert "Improve health checks in example docker-compose and clarify u…
37aef76 
…sage (#29408)"

This reverts commit 08bec93.
Taragolis added a commit that referenced this pull request Feb 21, 2023
@Taragolis
Revert "Improve health checks in example docker-compose and clarify u…
a8124e3 
…sage (#29408)"

This reverts commit 08bec93.
Taragolis added a commit that referenced this pull request Feb 22, 2023
@Taragolis
Revert "Improve health checks in example docker-compose and clarify u…
ab54df3 
…sage (#29408)"

This reverts commit 08bec93.
Taragolis added a commit that referenced this pull request Feb 23, 2023
@Taragolis
Revert "Improve health checks in example docker-compose and clarify u…
793be81 
…sage (#29408)"

This reverts commit 08bec93.
Taragolis added a commit that referenced this pull request Feb 23, 2023
@Taragolis
Revert "Improve health checks in example docker-compose and clarify u…
026f597 
…sage (#29408)"

This reverts commit 08bec93.
@pierrejeambrun pierrejeambrun added this to the Airflow 2.5.2 milestone Feb 27, 2023
@pierrejeambrun pierrejeambrun added the type:doc-only Changelog: Doc Only label Feb 27, 2023
pierrejeambrun pushed a commit that referenced this pull request Mar 7, 2023
@Taragolis @pierrejeambrun
Improve health checks in example docker-compose and clarify usage (#2…
7c30d75 
…9408)

* Improve health checks in example docker-compose and clarify usage
* Apply suggestions from code review

---------

Co-authored-by: Bas Harenslak <BasPH@users.noreply.github.com>
(cherry picked from commit 08bec93)
pierrejeambrun pushed a commit that referenced this pull request Mar 8, 2023
@Taragolis @pierrejeambrun
Improve health checks in example docker-compose and clarify usage (#2…
ed429f0 
…9408)

* Improve health checks in example docker-compose and clarify usage
* Apply suggestions from code review

---------

Co-authored-by: Bas Harenslak <BasPH@users.noreply.github.com>
(cherry picked from commit 08bec93)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BasPH BasPH BasPH left review comments

@potiuk potiuk potiuk approved these changes

Assignees
No one assigned
Labels
kind:documentation type:doc-only Changelog: Doc Only
Projects
None yet
Milestone
Airflow 2.5.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Taragolis @potiuk @BasPH @pierrejeambrun