Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mount kerberos.keytab to worker when enable #29526

Merged
merged 9 commits into from
Mar 5, 2023
Merged

Conversation

npsables
Copy link
Contributor

I believe kerberos.keytab and others should be mounted to worker container when enabling kerberos. We may want to reuse these files, for example, to spark-submit jobs. Maybe #24369 is a good reference for this pr.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Feb 14, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 14, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk
Copy link
Member

potiuk commented Feb 20, 2023

Can you please add tests covering that one @npsables ? I think if you add tests, it will be immediately visible what effect it will have.

@npsables
Copy link
Contributor Author

Hi sorry for late reply. I observed that my keytab cannot be found (in worker pods) when enabling Kerberos in helm, it doesn't make sense at all. People may want to use it for other services.

If you still think this is a good idea, I can create a testcase (check if kerberos.keytab exists after render) for this PR.

@potiuk
Copy link
Member

potiuk commented Feb 26, 2023

If you still think this is a good idea, I can create a testcase (check if kerberos.keytab exists after render) for this PR.

Yes. Adding tests is useful to show that. We generally expect all the changes to be covered by tests. So showing tests especially ones that have assertions showing the behaviour you observed (and failing because of that if your change is not implemented) is exactly that is needed.

@npsables
Copy link
Contributor Author

Hi, I added a testcase. Also I notice this function name is misspelled (keberos). Do you want me to change it too?

def test_keberos_sidecar_resources_are_not_added_by_default(self):

@potiuk
Copy link
Member

potiuk commented Mar 4, 2023

Static checks need fixing.

@npsables
Copy link
Contributor Author

npsables commented Mar 4, 2023

All good now

@potiuk potiuk merged commit ab22544 into apache:main Mar 5, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 5, 2023

Awesome work, congrats on your first merged pull request!

@potiuk
Copy link
Member

potiuk commented Mar 5, 2023

Indeed.

@potiuk potiuk added this to the Airflow Helm Chart 1.9.0 milestone Mar 5, 2023
@npsables
Copy link
Contributor Author

npsables commented Mar 5, 2023

This is actually the first time I have contributed to any opensource. It's meaningful to me. Thanks a lot!

@potiuk
Copy link
Member

potiuk commented Mar 5, 2023

Cool. Maybe you would like to take part in this campaign? https://news.apache.org/foundation/entry/the-asf-launches-firstasfcontribution-campaign - fill-in a short form and the ASF marketing team will contact you if they would like to get more insight :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants