Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect if 'docker-compose' existing #29544

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Conversation

Jianxuan-Li
Copy link
Contributor

use "docker compose" instead of "docker-compose" if the latter doesn't there.

related: #29542

@boring-cyborg
Copy link

boring-cyborg bot commented Feb 14, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk potiuk merged commit 84b13e0 into apache:main Feb 15, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 15, 2023

Awesome work, congrats on your first merged pull request!

@potiuk potiuk linked an issue Feb 15, 2023 that may be closed by this pull request
2 tasks
@potiuk
Copy link
Member

potiuk commented Feb 15, 2023

Thanks!

@Jianxuan-Li
Copy link
Contributor Author

Thank you!

@pierrejeambrun pierrejeambrun changed the title detect is 'docker-compose' existing detect if 'docker-compose' existing Feb 27, 2023
@pierrejeambrun pierrejeambrun added this to the Airflow 2.5.2 milestone Feb 27, 2023
@pierrejeambrun pierrejeambrun added changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) type:misc/internal Changelog: Misc changes that should appear in change log type:doc-only Changelog: Doc Only and removed changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) type:misc/internal Changelog: Misc changes that should appear in change log labels Feb 27, 2023
pierrejeambrun pushed a commit that referenced this pull request Mar 7, 2023
pierrejeambrun pushed a commit that referenced this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'docker compose' instead of 'docker-compose'
3 participants