-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and augment check-for-inclusive-language
CI check
#29549
Conversation
112984e
to
3a9ec1d
Compare
3a9ec1d
to
da85a59
Compare
da85a59
to
3a5a873
Compare
Related: apache#15994 apache#23090 This PR addresses a few items related to inclusive language use and the CI check: - There are several occurrences of "dummy" throughout documentation; however the current CI check for preventing non-inclusive language doesn't inspect `docs/` files. Ideally, the docs also include inclusive language. - Even when removing `docs/` from the exclusion list, non-inclusive language was still escaping pygrep. Upon inspection, the `(?x)` inline modifier was missing from the regex (although intended in apache#23090). Adding this modifier revealed these "dummy" instances and others related non-inclusive occurrences which were previously uncaught. - The exclusion list seemed too broad in places. There are still instances in which directories are excluded as a whole, but the list now is more tailored to non-inclusive occurrences that are beyond the purview of Airflow, history, dev/test files, etc.
3a5a873
to
34a2caa
Compare
Force pushing to hopefully get passed the test_cli_internal_api_background test now that it's quarantined. Thanks @Taragolis! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn’t check the exclude list; otherwise looks good to me.
Requires a bunch of CI/dev commits to avoid conflicts on |
Related: #15994 #23090
This PR addresses a few items related to inclusive language use and the CI check:
docs/
files. Ideally, the docs also include inclusive language.docs/
from the exclusion list, non-inclusive language was still escaping pygrep. Upon inspection, the(?x)
inline modifier was missing from the regex (although intended in Use inclusive words in apache airflow project #23090). Adding this modifier revealed these "dummy" instances and others related non-inclusive occurrences which were previously uncaught.