Specific use-case: adding packages via requirements.txt in compose #29598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like we need to be even more explicit about that one: #29597 |
Taragolis
approved these changes
Feb 17, 2023
pierrejeambrun
approved these changes
Feb 18, 2023
The users of docker compose do not realise that docker compose has built-in mechanism for rebuilding the image automatically when needed and do not realise that this does not make their workflows more complex. Apparently just describing how you can use custom images is either scary or not clear enough, as users keep on for dynamic way of adding the packages (which makes no sense if you use what docker-compose provides out-of-the-box) so it is worthwile to specifically mention "requirements.txt" and explicitly add all the steps needed to make requirements.txt and custom Docker image part of your regular workflow.
potiuk
force-pushed
the
clarify-special-case-for-docker-compose-custom-image
branch
from
a063d70
to
7b61d36
Compare
|
All comments reflected and docs building fixed. Merging |
potiuk
deleted the
clarify-special-case-for-docker-compose-custom-image
branch
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 7, 2023
…29598) The users of docker compose do not realise that docker compose has built-in mechanism for rebuilding the image automatically when needed and do not realise that this does not make their workflows more complex. Apparently just describing how you can use custom images is either scary or not clear enough, as users keep on for dynamic way of adding the packages (which makes no sense if you use what docker-compose provides out-of-the-box) so it is worthwile to specifically mention "requirements.txt" and explicitly add all the steps needed to make requirements.txt and custom Docker image part of your regular workflow. (cherry picked from commit a21c17b)
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 8, 2023
…29598) The users of docker compose do not realise that docker compose has built-in mechanism for rebuilding the image automatically when needed and do not realise that this does not make their workflows more complex. Apparently just describing how you can use custom images is either scary or not clear enough, as users keep on for dynamic way of adding the packages (which makes no sense if you use what docker-compose provides out-of-the-box) so it is worthwile to specifically mention "requirements.txt" and explicitly add all the steps needed to make requirements.txt and custom Docker image part of your regular workflow. (cherry picked from commit a21c17b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The users of docker compose do not realise that docker compose has built-in mechanism for rebuilding the image automatically when needed and do not realise that this does not make their workflows more complex. Apparently just describing how you can use custom images is either scary or not clear enough, as users keep on for dynamic way of adding the packages (which makes no sense if you use what docker-compose provides out-of-the-box) so it is worthwile to specifically mention "requirements.txt" and explicitly add all the steps needed to make requirements.txt and custom Docker image part of your regular workflow.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.