Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clear dag run openapi spec responses by adding additional return type #29600

Merged
merged 5 commits into from
Feb 20, 2023

Conversation

aliotta
Copy link
Contributor

@aliotta aliotta commented Feb 17, 2023

This Pr fixes the openapi documentation for the clearDagRun api. The api in question has two returns types depending on whether the dry_run param is true or false. Whilst it has no affect on the swagger ui at this time documenting these other return types helps when using code generation and will help us when openapi starts using the multiple return types in its ui.

@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Feb 17, 2023
@bbovenzi
Copy link
Contributor

In airflow/www could you run yarn run generate-api-types. That should help with some static check failures. We may need to change some API tests too

@aliotta aliotta changed the title fix clear dag run api responses by adding additional return type fix clear dag run openapi spec responses by adding additional return type Feb 18, 2023
@potiuk potiuk merged commit 54c4d59 into apache:main Feb 20, 2023
@pierrejeambrun pierrejeambrun added this to the Airflow 2.5.2 milestone Feb 27, 2023
@pierrejeambrun pierrejeambrun added the type:bug-fix Changelog: Bug Fixes label Feb 27, 2023
pierrejeambrun pushed a commit that referenced this pull request Mar 7, 2023
pierrejeambrun pushed a commit that referenced this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants