Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DbtCloudJobRunAsyncSensor #29695

Merged
merged 9 commits into from
Feb 23, 2023
Merged

Add DbtCloudJobRunAsyncSensor #29695

merged 9 commits into from
Feb 23, 2023

Conversation

phanikumv
Copy link
Contributor

This PR donates DbtCloudJobRunAsyncSensor from astronomer-providers repo to OSS Airflow


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Contributor

@josh-fell josh-fell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to add unit tests for this as well.

airflow/providers/dbt/cloud/sensors/dbt.py Outdated Show resolved Hide resolved
airflow/providers/dbt/cloud/sensors/dbt.py Show resolved Hide resolved
airflow/providers/dbt/cloud/sensors/dbt.py Outdated Show resolved Hide resolved
airflow/providers/dbt/cloud/sensors/dbt.py Outdated Show resolved Hide resolved
Copy link
Contributor

@dimberman dimberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments but overall this looks good to me 👍

airflow/providers/dbt/cloud/sensors/dbt.py Outdated Show resolved Hide resolved
@phanikumv
Copy link
Contributor Author

It would be great to add unit tests for this as well.

added unit tests

@kaxil kaxil merged commit e6d3176 into apache:main Feb 23, 2023
@kaxil kaxil deleted the dbt_sensor_async branch February 23, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants