-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid including fallback message for S3TaskHandler if streaming logs #29708
Conversation
This checks the metadata for the log_pos and if it is present and greater than 1 it doesn't include the "Falling back to local log" message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, with one suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits, feel free to ignore. 👍
Co-authored-by: Daniel Standish <15932138+dstandish@users.noreply.github.com> Co-authored-by: Philippe Gagnon <12717218+pgagnon@users.noreply.github.com>
Co-authored-by: Philippe Gagnon <12717218+pgagnon@users.noreply.github.com>
what version of airflow will this fix be included in? |
Its in amazon providers 7.3.0 PS: Airflow 2.5.2+ |
This checks the metadata for the log_pos and if it is present and greater than 1 it doesn't include the "Falling back to local log" message.
closes: #29393
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.