Update docs re: template_fields typing and subclasses #29725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very common question answered. |
uranusjr
approved these changes
Feb 23, 2023
uranusjr
reviewed
Feb 23, 2023
eladkal
approved these changes
Feb 23, 2023
josh-fell
force-pushed
the
template-fields-docs
branch
from
42bfb21
to
9c30997
Compare
Related: apache#22154 As a suggestion from [this issue comment](apache#22154 (comment)), this PR adds some color on the expected typing `template_fields` in operators as well as how to add other fields via subclassing as a common use case how-to.
josh-fell
force-pushed
the
template-fields-docs
branch
from
9c30997
to
1a7ef88
Compare
uranusjr
changed the title
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 7, 2023
(cherry picked from commit 28573c9)
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 8, 2023
(cherry picked from commit 28573c9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #22154
As a suggestion from this issue comment, this PR adds some color on the expected typing
template_fieldsin operators as well as how to add other fields via subclassing as a common use case how-to.