Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Liveness/Readiness Probe timeouts configurable for PgBouncer Exporter #29752

Merged
merged 2 commits into from
Feb 27, 2023

Conversation

nuclear0wl
Copy link
Contributor

Closes: #28891

The Pull Request makes Timeouts of Liveness and Readiness Probes for PgBouncer Metrics Exporter configurable. This change allows to provide more stability because it may be necessary to adjust these timeouts in slow environments where it takes more time to execute probes and avoid unnecessary container restarts and failures of Airflow tasks due to the unreachable PgBouncer.

@boring-cyborg
Copy link

boring-cyborg bot commented Feb 24, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

},
"periodSeconds": {
"description": "Metrics Exporter liveness probe frequency",
"format": "int32",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does helm honor these formats? We don't have them for anything else, and the one instance of it for periodSeconds in the upstream k8s schema has this as int64.

I'd be inclined to just remove all the formats you are adding here, unless you are sure helm actually checks them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed it again and pretty agree that it's quite extra to be here. Removed format fields, thank you!

@jedcunningham jedcunningham merged commit 44f89c6 into apache:main Feb 27, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 27, 2023

Awesome work, congrats on your first merged pull request!

@jedcunningham
Copy link
Member

Thanks @nuclear0wl! Congrats on your first commit 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pgbouncer metrics exporter restarts
3 participants