Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DAG loading in Graph view when using Dynamic Tasks #29791

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

Josersanvil
Copy link
Contributor

@Josersanvil Josersanvil commented Feb 27, 2023

closes: #27483

This PR just makes a small change to the function inwww that loads the DAG view for the Web UI.

Right now, the view loops and retrieves the mapped instances of all the expansions of a single task, that means that if a DAG created 100 expansions of a task instance, it loops through all the 100 expansions in order to retrieve the status of the 100! This makes the loading of that view very slow, and it is also not needed, applying the same logic, we only need to retrieve the mapped instances of one of the expansions to get the status of the rest (Since they all share the same Task Id).


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Feb 27, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 27, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed get_instance_with_map returns a summary for all mapped task and doesn't need to be run for each index.

Tested locally and looking good :)

@pierrejeambrun
Copy link
Member

pierrejeambrun commented Feb 28, 2023

We might still have an issue with the try_number, but this was already the case before. (try_number is shared for a specific task_id, we will pick the value of the first mapped task returned by dag.get_task_instances, which seems weird).

edit: I just looked at the equivalent in the grid view, and we do not return a 'try_number' for mapped task summaries. (which makes sense I believe)

Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! LGTM

@bbovenzi bbovenzi added this to the Airflow 2.5.2 milestone Feb 28, 2023
@bbovenzi bbovenzi merged commit 60d98a1 into apache:main Feb 28, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 28, 2023

Awesome work, congrats on your first merged pull request!

@potiuk
Copy link
Member

potiuk commented Feb 28, 2023

Sounds like a good candidate for the next PR of the month ;)

@pierrejeambrun pierrejeambrun added the type:misc/internal Changelog: Misc changes that should appear in change log label Feb 28, 2023
@jedcunningham
Copy link
Member

(#protm so @potiuk's nomination gets found by the automation!)

Congrats on your first commit @Josersanvil 🎉

pierrejeambrun pushed a commit that referenced this pull request Mar 7, 2023
pierrejeambrun pushed a commit that referenced this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DAG loading very slow in Graph view when using Dynamic Tasks
6 participants