Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates values.yaml config.kubernetes to config.kubernetes_executor #29818

Merged
merged 2 commits into from
Mar 17, 2023
Merged

updates values.yaml config.kubernetes to config.kubernetes_executor #29818

merged 2 commits into from
Mar 17, 2023

Conversation

N-ickJones
Copy link
Contributor

closes: #29817

When deploying Helm chart 1.8.0 the scheduler is expecting the airflow.cfg file to contain a kubernetes_executor section but, instead contains a kubernetes section. This change was introduced during the Airflow release v2.5.0 # Rename kubernetes config section to kubernetes_executor #26873

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Feb 28, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 28, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

jedcunningham
jedcunningham requested changes Feb 28, 2023
View reviewed changes
Copy link
Member

@jedcunningham jedcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @N-ickJones!

Unfortunately, it's not quite as simple as your proposed change. The latest version of the chart still supports older Airflow versions. Check out what was done for the logging config move.

@N-ickJones
Copy link
Contributor Author

Thanks for the PR @N-ickJones!

Unfortunately, it's not quite as simple as your proposed change. The latest version of the chart still supports older Airflow versions. Check out what was done for the logging config move.

For backwards compatibility do my updated changes work. Similar to the logging config move, add a duplicate section.

@potiuk
Copy link
Member

potiuk commented Mar 4, 2023

I think what @jedcunningham refers to is to add a comment explaining why this section is duplicated and ideally add condition on when it shoudl be removed.

jedcunningham
jedcunningham requested changes Mar 17, 2023
View reviewed changes
Copy link
Member

@jedcunningham jedcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good. A couple comments and we should be good to merge this!

chart/values.yaml Outdated Show resolved Hide resolved
jedcunningham
jedcunningham reviewed Mar 17, 2023
View reviewed changes
chart/values.yaml Outdated Show resolved Hide resolved
chart/values.yaml Show resolved Hide resolved
@N-ickJones N-ickJones force-pushed the issue-29817-kubernetes-executor-valuesfile-config branch 3 times, most recently from 6200d20 to 93b73ca Compare March 17, 2023 17:43
@N-ickJones
update values.yaml config.kubernetes_executor
2f18ada 
For backwards compatibility of Airflow <= 2.5.0
keeps the existing values.yaml `config.kubernetes`
and add a new `config.kubernetes_executor` section.

values.yaml `config.kubernetes` deprecation in Airflow >= 2.5.0.
values.yaml `config.kubernetes` deprecation of `airflow_` entries.
@N-ickJones N-ickJones force-pushed the issue-29817-kubernetes-executor-valuesfile-config branch from 93b73ca to 2f18ada Compare March 17, 2023 18:30
jedcunningham
jedcunningham reviewed Mar 17, 2023
View reviewed changes
chart/values.yaml Outdated Show resolved Hide resolved
@jedcunningham jedcunningham merged commit 4f3751a into apache:main Mar 17, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 17, 2023

Awesome work, congrats on your first merged pull request!

@jedcunningham
Copy link
Member

Thanks @N-ickJones! Congrats on your first commit 🎉

@N-ickJones
Copy link
Contributor Author

Thanks @N-ickJones! Congrats on your first commit 🎉

Thanks @jedcunningham @potiuk. I learned a lot from this experience.

@jedcunningham jedcunningham mentioned this pull request Apr 11, 2023
Closed
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedcunningham jedcunningham jedcunningham approved these changes

@dstandish dstandish Awaiting requested review from dstandish dstandish is a code owner

Assignees
No one assigned
Labels
area:helm-chart Airflow Helm Chart
Projects
None yet
Milestone
Airflow Helm Chart 1.9.0
Development

Successfully merging this pull request may close these issues.

Chart config section doesn't add kubernetes_executor to airflow.cfg
3 participants
@N-ickJones @potiuk @jedcunningham