-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove replicas if KEDA is enabled #29838
Conversation
needs static checks fixes and rebase. |
bba7fbf
to
6ae4686
Compare
Done, @potiuk. |
Looks like there are some side-effects of that change - the errors look quite related. |
Nope. It happens in main - we need to fix it there first. |
Can you please rebase @mabrikan -> I think the errors you see should have been fixed in main already, but it's good to double-check it. |
Sure thing 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. And the explanation is plausible. @jedcunningham @dstandish - any problem you see with removing replicas in this case?
I read a bit more and yeah - that's also official recommendation for HPA to not set replicas, so it should be OK to merge. https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#replicas @dstandish @jedcunningham - shout if you think otherwise :) |
Remove
replicas
field in workers Deployment/StatefulSet if KEDA is enabledGitOps operators (e.g. ArgoCD) complain when the manifest is changed due to KEDA/HPA auto-scaling. The good practice is to remove
replicas
field when auto-scaling is used.Reference:
https://argo-cd.readthedocs.io/en/stable/user-guide/best_practices/#leaving-room-for-imperativeness