Updating dag run endpoint to 404 if requested dag is inactive #29860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
approved these changes
Mar 2, 2023
uranusjr
approved these changes
Mar 3, 2023
eladkal
approved these changes
Mar 3, 2023
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 7, 2023
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit 751a995)
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 8, 2023
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit 751a995)
64 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #29839
The create dagrun API endpoint wasn't properly checking that a DAG was active and thus a user could try to trigger a DAG which had been removed from Airflow, which would throw a 500 because the DAG couldn't be loaded from the dagbag.
Updating this endpoint to look for active DAGs only.
Validated that this works as expected in breeze.