Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated k8s registry references #29938

Merged
merged 3 commits into from
Mar 8, 2023

Conversation

hussein-awala
Copy link
Member

k8s.gcr.io image registry will be frozen from the 3rd of April 2023 according to this announcement, and it was replaced by registry.k8s.io which contains already all the images.

@boring-cyborg boring-cyborg bot added area:helm-chart Airflow Helm Chart provider:cncf-kubernetes Kubernetes provider related issues labels Mar 6, 2023
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its impossible to set both 2.5.2 and helm chart milestone in a single PR :)

@jedcunningham jedcunningham added this to the Airflow 2.5.2 milestone Mar 6, 2023
@jedcunningham
Copy link
Member

2.5.2 is much more important to our workflow than the helm chart, so let's mark it for that one.

@hussein-awala
Copy link
Member Author

Its impossible to set both 2.5.2 and helm chart milestone in a single PR :)

@eladkal I can move the helm changes to a new PR if it's preferred. WDYT?

@eladkal
Copy link
Contributor

eladkal commented Mar 7, 2023

@eladkal I can move the helm changes to a new PR if it's preferred. WDYT?

That is up to @jedcunningham @ephraimbuddy as release managers for core and helm chart. If they don't mind than it's OK :)

@potiuk
Copy link
Member

potiuk commented Mar 8, 2023

Also - generally speaking helm chart is released from main - so once this one is merged, the next helm chart release will contain it. No need to put it to milestone.

@potiuk potiuk merged commit e0fadf9 into apache:main Mar 8, 2023
@pierrejeambrun pierrejeambrun added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Mar 8, 2023
pierrejeambrun pushed a commit that referenced this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) provider:cncf-kubernetes Kubernetes provider related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants