-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reformat chart templates part 2 #29941
Conversation
94e2941
to
607b5c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Spotted some indents that might need to be nindents, but it may not matter?
Did you intentionally skip the pod_template_file template?
Hi @jedcunningham!
They should not be nindented because it will add one extra new line, i.e. the following envFrom: {{- include "custom_airflow_environment_from" . | default "\n []" | nindent 10 }}
env: {{- include "custom_airflow_environment" . | nindent 10 }} produces envFrom:
- secretRef:
name: 'test-airflow-connections'
- configMapRef:
name: 'test-airflow-variables'
env:
# Dynamically created environment variables
- name: qwe
value: "rty"
# Dynamically created secret envs
# Extra env
- name: AIRFLOW__CORE__LOAD_EXAMPLES
value: 'True' while current implementation envFrom: {{- include "custom_airflow_environment_from" . | default "\n []" | indent 10 }}
env: {{- include "custom_airflow_environment" . | indent 10 }} produces envFrom:
- secretRef:
name: 'test-airflow-connections'
- configMapRef:
name: 'test-airflow-variables'
env:
# Dynamically created environment variables
- name: qwe
value: "rty"
# Dynamically created secret envs
# Extra env
- name: AIRFLOW__CORE__LOAD_EXAMPLES
value: 'True'
I skipped |
607b5c3
to
dc8df54
Compare
👍
Ah. Can those helpers not emit an extra leading newline instead? If you want to defer to when you tackle helpers, that's cool too. |
I don't know to be honest. I want to investigate it and refactor helpers separately. |
dc8df54
to
cb669d6
Compare
Fixed merge conflict introduced by commit e60be9e |
The PR reformats multiple chart templates as the continuation of #29917