Add deferrable AzureDataFactoryRunPipelineOperator
#30074
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:microsoft-azure
phanikumv
changed the title
AzureDataFactoryRunPipelineOperator
phanikumv
force-pushed
the
azure_pipeline_asyncop
branch
from
702df16
to
4a84704
Compare
phanikumv
changed the title
AzureDataFactoryRunPipelineOperatorAzureDataFactoryRunPipelineOperator
pankajastro
reviewed
Mar 15, 2023
josh-fell
reviewed
Mar 16, 2023
| @@ -30,7 +31,6 @@ class ADFPipelineRunStatusSensorTrigger(BaseTrigger): | |||
| """ | |||
| ADFPipelineRunStatusSensorTrigger is fired as deferred class with params to run the | |||
| task in trigger worker, when ADF Pipeline is running | |||
|
|
|||
There was a problem hiding this comment.
There needs to be an empty between docstring description and parameter directives to make sure the params are rendered correctly in the Python API docs.
Comment on lines
108
to
118
| QUEUED = "Queued" | ||
| IN_PROGRESS = "InProgress" | ||
| SUCCEEDED = "Succeeded" | ||
| FAILED = "Failed" | ||
| CANCELING = "Canceling" | ||
| CANCELLED = "Cancelled" | ||
|
|
||
| INTERMEDIATE_STATES: list[str] = [QUEUED, IN_PROGRESS, CANCELING] | ||
| FAILURE_STATES: list[str] = [FAILED, CANCELLED] | ||
| SUCCESS_STATES: list[str] = [SUCCEEDED] | ||
| TERMINAL_STATUSES: list[str] = [CANCELLED, FAILED, SUCCEEDED] |
There was a problem hiding this comment.
AzureDataFactoryPipelineRunStatus already exists so let's use that. No problem augmenting the status groups too with INTERMEDIATE_STATUSES and FAILURE_STATUSES. I don't think SUCCESS_STATES is needed though since the logic could be pipeline_status == AzureDataFactoryPipelineRunStatus.SUCCESS. TERMINAL_STATUSES already exists in AzureDataFactoryPipelineRunStatus.
|
|
||
| .. exampleinclude:: /../../tests/system/providers/microsoft/azure/example_adf_run_pipeline.py | ||
| :language: python | ||
| :dedent: 0 |
There was a problem hiding this comment.
Suggested change
| :dedent: 0 | |
| :dedent: 4 |
So the code snippet doesn't have extra whitespace on its left side in the docs.
phanikumv
force-pushed
the
azure_pipeline_asyncop
branch
from
f6472c8
to
971e322
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR donates the deferrable AzureDataFactoryRunPipelineOperator from astronomer-providers to airflow repo.
cc @josh-fell
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.